[Problem] MPF includes AA.2 track generated by Redumper when looking for Redump matches

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#

GNU General Public License v3.0

405 stars 34 forks source link

[Problem] MPF includes AA.2 track generated by Redumper when looking for Redump matches #640

Closed NovaSAurora closed 6 months ago

NovaSAurora commented 6 months ago

Version What version are you using?

[X] Stable release (3.0.3)

Build What runtime version are you using?

[X] .NET 6.0 running on (W11)

Describe the issue When dumping a multisession disc with Redumper and a AA.2 track is generated, MPF includes this when looking for db matches on Redump.org

Screenshots

Deterous commented 6 months ago

Expected functionality is that only tracks with positive numbers should be checked against redump.org? i.e. Track 1, 2, 3, ... only? not: Track 0, A, AA1, B, 2B, whatever, etc?

Currently it works on denylist for 0, 0.2, 00, 00.2, A, AA Rather than add another line for AA.2, it may be easier to only allow positive integers?

mnadareski commented 6 months ago

The .X at the end is the session number. There are generally a max of 2 sessions on a disc, so I think it's safe to do so.

Deterous commented 6 months ago

Current: 0, 0.2, 00, 00.2, A, AA Add: AA.2 What about A.2? Is there anything else you can conceive occurring?

mnadareski commented 6 months ago

Basically every variant can optionally have a .2 suffix. In theory, if there was a disc with more sessions, those would be suffixed with their respective session numbers. Given that .2 is rare enough and I haven't personally seen a .3, I think it's safe to just hardcode a new value in the list for now. If there's a reason to make it more extensible in the future, then we can do so.