SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
405 stars 34 forks source link

[Problem] `aaru` does not work with used drive letter #652

Closed Whovian9369 closed 5 months ago

Whovian9369 commented 5 months ago

Before You Submit

Version What version are you using?

Build What runtime version are you using?

Describe the issue Aaru 5.3.2 does not like currently used drive letter (For example "D:\") when starting a dump via MPF.

To Reproduce Steps to reproduce the behavior:

  1. Select "Aaru" from "Dumping Program" drop down
  2. Start dump
  3. See error

Expected behavior I expected dump to begin.

Screenshots [No screenshots available]

Additional context Aaru 5.3.2 doesn't appear to like drive letters appended with \, and removing that character may fix this issue. (So "D:" may work, though I didn't test it with quotes.) Currently, that returns a message saying that a required argument is missing, and then prints the help information for the dump command. Example output: media dump --force True --store-encrypted True --title-keys False --trim True --speed 16 --retry-passes 5 "D:\" "ISO\MyImage\MyImage.aaruf"

Required argument missing for command: dump

dump:
  Dumps the media inserted on a device to a media image.

Usage:
  aaru media dump [options] <device-path> <output-path>

Additionally, it seems to not like drive letters without a colon (:) appended. Example of that happening via Aaru itself: media dump --force True --speed 16 --retry-passes 5 "D" "MyImage.aaruf"

aaru 5.3.2+f4fef21d
Copyright © 2011-2023 Natalia Portillo

Exception of type 'Aaru.Devices.DeviceException' was thrown.

What worked was media dump --force True --speed 16 --retry-passes 5 D: "MyImage.aaruf"

aaru 5.3.2+f4fef21d
Copyright © 2011-2023 Natalia Portillo

Output image format: Aaru Format.
Device in database since 12/30/2021 9:27:34 AM.

PFI:
...