SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
400 stars 35 forks source link

Custom non-redump Redumper options #691

Closed Deterous closed 2 months ago

Deterous commented 2 months ago

Currently, MPF UI options allows for Redumper BE_CDDA mode and GENERIC drive type. These are somewhat arbitrary (e.g. why not also allow BE mode, or other drive types) and more importantly can misinform users who may set these options without knowing that they are not supported for redump submission.

This PR gates GENERIC drive mode behind a new "Non-Redump Mode", as well as extends read method beyond just BE_CDDA, and adds a new sector order option (Fixes #690 )

Preview: image

Checking non-redump options shows a warning: image

The advanced Redumper options can now be set. image

Unchecking Non-Redump Options resets the three options back to their defaults.

Deterous commented 2 months ago

Changed the combo boxes (and textboxes) to a fixed width image