search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
399 stars 35 forks source link

[Problem] Incorrect media type detection with small UDF DVD #710

Open mictlantecuhtle opened 2 weeks ago

mictlantecuhtle commented 2 weeks ago

Version What version are you using?

Build What runtime version are you using?

Describe the issue Attempt to detect media type for a very small UDF DVD-ROM (164MB) incorrectly detects the disc as a CD-ROM.

Scanning for drives..
Found 2 drives: E:\, F:\
Trying to detect system for drive F:\.. unable to detect.
Trying to detect media type for drive F:\ [UDF] using size and filesystem.. Detected CD-ROM.
Supported media speeds: 1, 2, 3, 4, 6, 8, 12, 16, 20, 24, 32, 40, 44, 48, 52, 56, 72
Setting drive speed to: 16
Local version: 3.2.0
Remote version: 3.2.0
You have the newest version!

An attempt to dump with redumper (without changing media type) will result in a successful dump but cause the process to fail at protection scan/info gathering. DIC will refuse to dump due to being passed the wrong media type.

To Reproduce Steps to reproduce the behavior:

  1. Insert a sufficiently small DVD-ROM with a UDF filesystem
  2. Click "Scan for discs"
  3. Check to see which media type has been detected

Expected behavior

The disc to be detected as a DVD-ROM

Additional context The disc in question is Side A of the first disc of Cartoon Network Power Pack, consisting of two double-sided discs, each with a DVD-Video and a DVD-ROM side (https://www.ebay.co.uk/itm/195943982458)

Deterous commented 2 weeks ago

This is a known problem, but good to log it here on github. It comes down to there currently not being a good method for MPF to properly detect media type, and DIC requiring prior knowledge of it. For now, the user has to correct it before dumping with DIC. At least its an error that's produced and not a bad dump. Perhaps a future version will be smart enough (without doing Windows-specific API calls, something sabre does not want in MPF).