SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
409 stars 35 forks source link

[Problem] MPF UI media type set incorrectly if tick/untick parameters tickbox #719

Closed JohnVeness closed 2 months ago

JohnVeness commented 2 months ago

Version What version are you using?

Build What runtime version are you using?

Describe the issue The media type box can get changed to an incorrect type simply by ticking then unticking the box to the right of parameters.

To Reproduce Steps to reproduce the behavior:

  1. Download and unzip MPF.Check_3.2.0_net8.0_win-x64_release.zip in a new folder (so, not copying over any previous options)
  2. Insert a PS2 DVD game in the ODD
  3. Run MPF.exe
  4. Notice that it detects System: Sony PlayStation 2, media type: DVD-ROM correctly
  5. Tick the box to the right of Parameters
  6. Don't make any changes in Parameters, in fact don't even click within it
  7. Untick the box to the right of Parameters

Observed behavior System remains as before (System: Sony PlayStation 2) but media type changes from DVD-ROM to CD-ROM. If you dump in this state you will get an error about files missing.

Expected behavior Detected system and media type should stay as before (System: Sony PlayStation 2, media type: DVD-ROM).

Additional context Clicking "Scan for discs" after ticking/unticking the box will set the media type correctly again.

As options are set to default, the dumping program MPF is using is Redumper.

JohnVeness commented 2 months ago

Many thanks :)