search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
409 stars 35 forks source link

[Problem] The "Overwrite?" window incorrectly identifies a Redumper dump as an Aaru dump #723

Open TheRogueArchivist opened 1 month ago

TheRogueArchivist commented 1 month ago

Version

Build

Describe the issue When trying to create an image in a directory that contains a finished Redumper image, MPF misidentifies it as an Aaru image.

To Reproduce

  1. Create a dump with Redumper.
  2. Without changing the output directory, attempt to create another dump. In my case, I changed the tool to DIC first but I don't believe this is necessary.
  3. See error

Expected behavior I would expect MPF to identify the completed dump properly as a Redumper image.

Screenshots

MPF_AkSgSyWlJy

Deterous commented 1 month ago

As you're trying to dump with DIC, it tries to look for a complete DIC dump (i.e. at least a .img file and the logs zip). It doesn't find it, so it goes through these methods: https://github.com/SabreTools/MPF/blob/2983266e8aaf0252f87728f3ecf254180265f16e/MPF.Frontend/DumpEnvironment.cs#L151 Aaru is the first one attempted, which only looks for the logs zip, and matches immediately. I would suggest a simple solution would be to just change the order and look for DIC first, then Redumper, then Aaru.

TheRogueArchivist commented 1 month ago

I'd personally say a more identifying check would be good, possibly in addition to reordering. For example, DIC should still be the only one producing an IMG while Redumper is definitely the only one producing a scram/scrap file.