search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
427 stars 34 forks source link

Fix logic for deducing region from PlayStation ISN #724

Closed JohnVeness closed 3 months ago

JohnVeness commented 3 months ago

An attempt to fix #722. Please note that I am a complete C# amateur and don't know whether this is the best implementation! And I haven't added it for PS1.

I'm a bit confused about line https://github.com/JohnVeness/MPF/blob/8c9b51914850f583cd70576f500673427d9f4a78/MPF.Frontend/Tools/SubmissionGenerator.cs#L837 which doesn't seem to get executed.

Deterous commented 3 months ago

I'm a bit confused about line https://github.com/JohnVeness/MPF/blob/8c9b51914850f583cd70576f500673427d9f4a78/MPF.Frontend/Tools/SubmissionGenerator.cs#L837 which doesn't seem to get executed.

I think you've spotted the issue at hand; this line was copy-pasted from the other setters but the logic is different as the ISN is being used, not set. So the fix here is if ISN is set (trygetvalue is true, isnullorempty is false) -> set region with GetPlayStationRegion

This logic will need to change for KP2, PSX, and PS2 systems (all inside SubmissionGenerator.cs)

JohnVeness commented 3 months ago

Aha, thanks for spotting that. I have made several changes and I think it's now good.

Please triple-check my work before merging (or completely ignore this PR and make your own change!) as I really don't know what I'm doing. You'll probably want to squash the commits into one, too.