search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
409 stars 35 forks source link

Use actual filenames in report #725

Closed JohnVeness closed 1 month ago

JohnVeness commented 1 month ago

Changes, for example, Writing information to !submissionInfo.txt... to Writing information to !submissionInfo_isoname.txt....

mnadareski commented 1 month ago

The code looks fine, but why are you making this change?

JohnVeness commented 1 month ago

It just annoyed me it saying it was outputting to !submissionInfo.txt when it wasn't actually doing so in some circumstances!

Alternatively, I'd be OK if the text was more general like Writing submission information... or Writing protection information... or Writing submission information as JSON... rather than mentioning the actual filenames.

mnadareski commented 1 month ago

I don't see any problem with the current code before this change, but if I were given a choice, I'd prefer the more generic language to matching the output name entirely at that point.

JohnVeness commented 1 month ago

It's up to you, of course! This was just me scratching an itch.

Happy to do another PR with generic text, if you let me know.

mnadareski commented 1 month ago

Please change it to the more generic language and I will merge it. Just update this PR, no need to close this one and open a new one.

JohnVeness commented 1 month ago

Sorry, had a problem with git branches so ended up making a new PR (#727) after all. Still, at least it gives you a choice!