SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
437 stars 34 forks source link

[Problem] MPF does not zip [dump].0.manufacturer file #746

Closed TurnedToast closed 2 months ago

TurnedToast commented 2 months ago

Occurs in current stable and today's WIP, .NET 8.0 running on Windows 11

Describe the issue When dumping [PS2] Sakura Wars: So Long My Love, which has two dual-layer DVDs, redumper outputs two .manufacturer files:

  1. [title].0.manufacturer
  2. [title].1.manufacturer

After finishing the dump and filling info, the compression of the log files does not include the "0" manufacturer file and leaves the file chilling outside the zip

To Reproduce Dump a dual layer PS2 game. I don't have any non-PS2 dual layer DVDs to test, but based on the code this could be an issue for any DVD media.

This ocureed for the two Sakura Wars discs and a Yakuza 2 disc I tested

Expected behavior all .manufacturer files are zipped

Additional context in MPF.Processors\Redumper.cs under case MediaType.DVD, the .physical file list accounts for 0, 1, and 2 .physical, but for .manufacturer names it only returns 1 and 2. Adding another entry for $"{baseFilename}.0.manufacturer" fixes the issue for my disks