search

SacArea-BayDeltaProjects / HydroRDITemplate

CR1000 and CR6 Datalogger template for RDI ADCPs
2 stars 0 forks source link

Comms Mode for Max232 on CR6 #28

Closed violetteta8 closed 5 years ago

violetteta8 commented 5 years ago

For CR6 loggers using ComC1 or ComC3 with a Max232, we need to use TTL logic instead of RS232. Need to update the SerialOpen commands FROM: If UseComms(zero)ForSonde=True Then SerialOpen(WqSerialPort,WqBaud,19,0,2000,0) (Change variable name from UseCommsZeroForSonde to UseCommsOneForSonde for consistency's sake). TO: If UseComms(zero)ForSonde = True Then SerialOpen(WqSerialPort,WqBaud,19,0,2000,1)

Need to investigate ADCP port as well.

violetteta8 commented 5 years ago

Let's investigate the U-ports to see if this is the same for them. Then build in some logic to say something like "If WqSerialPort = ComC1 OR WqSerialPort = C3 Then use mode 1, Else, use mode 0.

USGSminc commented 5 years ago

Made pull request change WQ data type and variables only. We can address ADVM later.

violetteta8 commented 5 years ago

Merged WQ pull request.

violetteta8 commented 5 years ago

CommsModeOneForSonde didn't work at Shag. With no Max232 I had to set that value to False to get data to come in. Haven't had a chance to look at it. But we need to address it.

USGSminc commented 5 years ago

Sorry, I completely forgot that Shag didn't have a max 232 for the sonde. I changed the com setting for the max 232 from 0 to 1 to make the max 232 work. I looked over the commit and it looks like I misread the If then statement. If max232 is present then we change to CommsModeOne else we need to retain CommsModeZero for when it is only using serial. That should work. I am not sure how that changes thins on line 5069 and 5075.

violetteta8 commented 5 years ago

Mark fixed this and it works. If using Max232 with Doppler and having issues, look into comms mode and SerialOpenFormat.