search

SachinGanesh / screenshot

Flutter Screenshot Library
https://pub.dev/packages/screenshot
MIT License
327 stars 137 forks source link

Update ViewConfiguration parameters for Flutter 3.18.0 + api change #158

Closed timmaffett closed 3 months ago

timmaffett commented 7 months ago

This PR makes the required API changes to the ViewConfiguration() constructor call in widgetToUiImage().

ViewConfiguration now takes constraints: ui.ViewConstraints(maxWidth: logicalSize.width, maxHeight: logicalSize.height), instead of size: logicalSize,

egedib commented 6 months ago

@SachinGanesh can you do a little bit of testing and merge if it's ok?

timmaffett commented 6 months ago

I would hold off merging this because they have reverted the ViewConfiguration change currently. I will update when/if they re-merge the change into the master channel.

lukemmtt commented 6 months ago

For anyone wanting to follow the underlying Flutter SDK changes & discussion:

timmaffett commented 5 months ago

OK, I think they have finalized the changes to ViewConfiguration and I have updated the PR to reflect these changes.

ritheshSalyan commented 3 months ago

@timmaffett , Thank you for your pull request. We have implemented this change for version 2.2.0. Closing in favor of e92762a71e5dcd39e0aae6bf4399b5947f09c91d