SacredSkull / untitled-incremental

Some kind of vague incremental clicker...
1 stars 0 forks source link

Project shouldn't need sub-types #15

Closed SacredSkull closed 9 years ago

SacredSkull commented 9 years ago

Software/Hardware projects share the same attributes bar

I don't feel the need to create a whole new class which creates messy XML code parsing.

Rather than use

<SoftwareProject ... />

I propose

<Project type="software" ... />

In other words, adding a type of project which could be an enum (I've had some strange behaviour in Unity/C# with them so may just go with a string instead).

For software projects, the parts list is empty; for hardware projects, the points cost is zero.

Hanso38 commented 9 years ago

Still required?

SacredSkull commented 9 years ago

What do you mean

Hanso38 commented 9 years ago

In light of your commit does this change still need to be made?

SacredSkull commented 9 years ago

Well, yes. I was much too tired to do it last night and just fired in an issue

Hanso38 commented 9 years ago

Done

SacredSkull commented 9 years ago

Btw, you should generally mention the commit that just fixed it if it's specific enough like this

SacredSkull commented 9 years ago

Fixed as per https://github.com/SacredSkull/untitled-incremental/commit/50f0a12f6528a7f43279c37a500b3cd3d1813275