feat: fixes and refactors

Sacristan / godot_scene_object_brush

Scene drawing/placement brush addon for Godot game engine.

https://godotengine.org/asset-library/asset/2557

The Unlicense

25 stars 1 forks source link

feat: fixes and refactors #8

Closed joelgomes1994 closed 1 month ago

joelgomes1994 commented 1 month ago

Hello! Sorry for the long pull request.

Fix random rotation not being applied correctly (specially on flat planes)
Spawned objects are named as "OriginalInstanceName_Timestamp" (instead of "BrushName_Timestamp")
Add icon to Brush node
Comply with the GDScript Style Guide in variable and method names
Document variables and methods in the Brush class
Removed class_name from BrushEditor (only Brush needs this)

The style guide is the only change that may break existing installations (as the export variables were change from camelCase to snake_case), but nothing too serious.

By the way, thanks for the plugin, very handy!

joelgomes1994 commented 1 month ago

Actually, there's a serious problem, the game scene is running at 60 FPS, but once I click the Brush node, the frame drops to less than 30 FPS, and even if I deselect it the FPS is still low. Probably the _process function is still running even if the Brush is deselected.

And when I close the scene, the output spams a call from the _process function due to already freed Brush node.

I must investigate this further on how to fix this.

joelgomes1994 commented 1 month ago

I will take a look at some issues I found, and I'll open another pull request when I'm done with it.

Sacristan commented 3 weeks ago

@joelgomes1994

i think the framedrop issue might be there before your changes as well :) Might be a mem leak somewhere. Ref #6
Removed class_name from BrushEditor (only Brush needs this). I prefer to write class_name when creating tools
Could you split changes in separate branches, so they could be merged in as separate features ?

Sorry for late answer - was down w Covid