Validation - Catch runtime exception for New Location Type as a error rather than bombing out.

Sadless74 / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed

0 stars 0 forks source link

Validation - Catch runtime exception for New Location Type as a error rather than bombing out. #113

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

If there is a wrong location_type, it should be raised as an error rather
than throwing an exception and ending validation.

Original issue reported on code.google.com by clancy.c...@gmail.com on 10 Nov 2008 at 11:08

GoogleCodeExporter commented 9 years ago

Thanks for accepting this. BTW testBadLocationType in test/testtransitfeed 
attempts
to test this
        "stops.txt",
        "stop_id,stop_name,stop_lat,stop_lon,location_type\n"
        "BEATTY_AIRPORT,Airport,36.868446,-116.784582,2\n"
        "BULLFROG,Bullfrog,36.88108,-116.81797,notvalid\n"
        "STAGECOACH,Stagecoach Hotel,36.915682,-116.751677,\n")

Original comment by tom.brow...@gmail.com on 10 Nov 2008 at 7:29

Added labels: App-FeedValidator, Language-Python, Type-Defect

GoogleCodeExporter commented 9 years ago

http://codereview.appspot.com/11051

Original comment by clancy.c...@gmail.com on 15 Dec 2008 at 7:28

Changed state: Started

GoogleCodeExporter commented 9 years ago

Fixed and uploaded in r956

Original comment by clancy.c...@gmail.com on 16 Dec 2008 at 10:30

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Issue 138 has been merged into this issue.

Original comment by tom.brow...@gmail.com on 27 Feb 2009 at 7:29