Sadless74 / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Recognize and Validate trip_short_name in trips.txt #172

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. validate a feed with trip_short_name in trips.txt (example dataset:
http://bit.ly/T29Ep)

What is the expected output? What do you see instead?
currently this column is flagged as an 'unknown column' even though it was
added to the spec on March 30th.

At a minimum remove this column from 'unknown' status. we should also 
validate that trip_short_name is unique per day, that it is != the trip
headsign, and that it does not contain the words limited,local or express.

Original issue reported on code.google.com by jehiah on 27 May 2009 at 2:17

GoogleCodeExporter commented 9 years ago
I agree. duplicate trip_short_name should be a warning and suggest a route with
route_short_name for related trips. Like route_short_name, len(trip_short_name) 
> 6
can be a warning.

Original comment by tom.brow...@gmail.com on 27 May 2009 at 2:38

GoogleCodeExporter commented 9 years ago
I think the check could be stronger than that--according to the spec two trips 
with
the same trip_short_name and the same service_id is an error.

Original comment by joe.hugh...@gmail.com on 27 May 2009 at 3:05

GoogleCodeExporter commented 9 years ago

Original comment by tom.brow...@gmail.com on 16 Nov 2009 at 4:42

GoogleCodeExporter commented 9 years ago
viger asked me to work on a related issue, this includes:
- adding 'trip_short_name' as a known column to validator.
- validation of the 'trip_short_name' according to the spec, "A trip_short_name 
value, if provided, should uniquely identify a trip within a service day; it 
should not be used for destination names or limited/express designations"

--> we will issue an error if the 'trip_short_name' is used more than once on 
the same day (service period weekdays and exceptions will be checked)

Original comment by n...@google.com on 16 Nov 2010 at 9:28

GoogleCodeExporter commented 9 years ago

Original comment by n...@google.com on 16 Nov 2010 at 9:28

GoogleCodeExporter commented 9 years ago
Thanks for taking this on, Moritz!  Your plan sounds good, and Fab has all the 
advice you need.  I'm un-cc'ing myself.

Arno

Original comment by arnoegw.code@gmail.com on 20 Nov 2010 at 3:16

GoogleCodeExporter commented 9 years ago
Moved to https://github.com/google/transitfeed/issues/172

Original comment by bdfer...@google.com on 7 Oct 2014 at 11:56