search

Sadless74 / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Validate agency_phone. #191

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Check that agency_phone field is provided and formatted correctly. Warn at 
the minimum. Thx!

Original issue reported on code.google.com by fredf...@gmail.com on 9 Oct 2009 at 4:30

GoogleCodeExporter commented 9 years ago 
Fred, can you provide more context for this request to help inform the fix?  Was
there a particular malformed value that caused problems?

Original comment by joe.hugh...@gmail.com on 9 Oct 2009 at 4:40

GoogleCodeExporter commented 9 years ago 
Eng is pretty strict about providing the agency_phone for launch. As a result, 
we
might as well warning if it doesn't exist. No point in having the team reactive 
tell
agencies that they need to include agency_phone. Thx!

Original comment by fredf...@gmail.com on 9 Oct 2009 at 4:47

GoogleCodeExporter commented 9 years ago 
I see--so Google now insists on a phone number for new agencies, so the main 
request
here is that we warn if it's not present.

Original comment by joe.hugh...@gmail.com on 9 Oct 2009 at 4:50

GoogleCodeExporter commented 9 years ago 
yep and if possible correlate with country to check for formatting. not sure if 
thats
too much though

Original comment by fredf...@gmail.com on 9 Oct 2009 at 4:55

GoogleCodeExporter commented 9 years ago 
Have we encountered any problems with formatting in practice?

Original comment by joe.hugh...@gmail.com on 9 Oct 2009 at 5:00

GoogleCodeExporter commented 9 years ago 
no not that i can remember

Original comment by fredf...@gmail.com on 9 Oct 2009 at 5:03

GoogleCodeExporter commented 9 years ago 
as this field is optional and this seems to be a google specific need, I think 
it should stay without a warning 
unless the specification is updated with stronger language about encouraged 
usage; also might be good to poll 
gtfs-changes to see about usage by other gtfs consumers. i suspect that not 
many consumers use this field (I 
don't use it so I could be biased).

Original comment by jehiah on 9 Oct 2009 at 7:33

GoogleCodeExporter commented 9 years ago 
Downgrading priority. We should fix things that everyone agrees are bad before 
this.

Original comment by tom.brow...@gmail.com on 30 Oct 2009 at 11:07

GoogleCodeExporter commented 9 years ago 
Moved to https://github.com/google/transitfeed/issues/191

Original comment by bdfer...@google.com on 8 Oct 2014 at 12:08