implemented some previously impossible features

Mar-Koeh commented 3 years ago

As I found your plugin quite handy (and wanted to practice a bit with OpenRCT2 plugin development), I tried to implement the previously impossible planned features. I hope that helps

Here is what I changed:

For maps with a guest goal, there is now a percentage with the soft guest gap.
An additional menu button now displays the soft guest gap that excludes broken rides
There is now code to detect harder guest generation parks. However, it isn't used yet.
A (also not yet used) stub function demonstrates how one could implement a check whether a ride qualifies for the bonus guest cap in harder guest generation parks.
A (again not yet used) function implements the guest cap for harder guest generation parks. As it relies on the stub function, it is not in use yet.

One could discuss whether the unfinished code on the harder guest generation case could be used as an estimation. For example: “The soft guest cap is between [harder generation soft guest cap without bonus] and [with some bonuses that might be exclude if the API told us more] ”

Sadret commented 3 years ago

Hi Mar-Koeh,

I am very sorry that it took me over half a year (plus a YouTube comment) to realize that I had a PR. I kind of abandoned this plug-in and focused on my other projects once it was up and running. I know changed my GitHub settings so that I will receive email notifications so that this never happens again.

Your changes are interesting and I am very thankful for your contribution. But since then a lot has changed in the plug-in API and most of the original plug-in code is now obsolete (e.g. you can now directly query the soft guest cap). Because of that, I am planning to rewrite the plug-in in the near future. I will see if I integrate any of your proposed changes and if so, I will happily give you credit for that.

If you have any more ideas, feel free to message me or comment here.

Mar-Koeh commented 3 years ago

Because of that, I am planning to rewrite the plug-in in the near future. I will see if I integrate any of your proposed changes and if so, I will happily give you credit for that.

Although this code is soon-to-be deprecated legacy code, I'm glad I could contribute to it.

Sadret commented 3 years ago

FYI: the new version is released.

Sadret / openrct2-soft-guest-cap-calculator

implemented some previously impossible features #1