search

Saeven / zf3-circlical-user

Turnkey Authentication, Identity, and RBAC for Laminas and Zend Framework 3. Supports Doctrine and Middleware.
Mozilla Public License 2.0
36 stars 15 forks source link

modified userresettokenmapper #26

Closed Zhuoqin closed 7 years ago

Zhuoqin commented 7 years ago
  1. Added an id getter in the UserRestToken entity.
  2. Updated the doctrine SQL ( * is undefined, set parameter should be after).
Saeven commented 7 years ago

Thank you for your contribution! This was indeed a newer corner of the lib; appreciate you using it.

You'll need to cherry pick or copy the travis yml from master so that travis runs tests on your fork. Then, we'll need to ensure proper test coverage.

Zhuoqin commented 7 years ago

Updated it based on your comments, thank you!

Saeven commented 7 years ago

Thanks so much - CI is green now. Can you add spec tests to satisfy the change for isValid()

Saeven commented 7 years ago

Will write tests, merging.