search

Saeven / zf3-circlical-user

Turnkey Authentication, Identity, and RBAC for Laminas and Zend Framework 3. Supports Doctrine and Middleware.
Mozilla Public License 2.0
36 stars 15 forks source link

Bump doctrine package versions #44

Closed Tigerman55 closed 5 years ago

Saeven commented 5 years ago

Thanks for submitting! I haven't dug into the package differences - the configs are identical? No BC breaks?

Tigerman55 commented 5 years ago

Just spent some additional time looking into it the release history for the bumps. The doctrine-module 2 update adds better support for zf3. The doctrine-orm-module update supports doctrine module 2 and php 7.2. The doctrine-orm update does have minor bc breaks, none of which will affect your library.

My primary reason for bumping these versions is to support doctrine migrations, which is best practice for doctrine schema updates.

Tigerman55 commented 5 years ago

Have you had a chance to look at this pr more closely? Would much appreciate it if you could look into merging it in.

Saeven commented 5 years ago

Sorry Tigerman! I'm having to check all my projects to see if I can bump, unfortunately I've found one that cannot be resolved.

Could you adjust your PR to use 'or' instead of an absolutely move to 2?

That'd take care of any fringe constraints, and would allow me to merge things right in.

Tigerman55 commented 5 years ago

Sure thing