Use setParameter on "string" value

Saeven / zf3-circlical-user

Turnkey Authentication, Identity, and RBAC for Laminas and Zend Framework 3. Supports Doctrine and Middleware.

Mozilla Public License 2.0

36 stars 15 forks source link

Use setParameter on "string" value #7

Closed kersten closed 8 years ago

Saeven commented 8 years ago

Hi Kersten!

Thanks for submitting a PR.

I'm curious as to the rationale behind the change. It isn't a parameter -- the value "string" remains the same. Seems it adds lines of code, and extra calls inside of Doctrine with no gain?

Let me know if I am being daft ;)

Cheers. Alex

kersten commented 8 years ago

Yes, I now. But at my setup ( all latest versions from composer ) I had a fatal error saying Error: Expected Literal, got '"'. After putting it into a Parameter, the error was gone. Sorry for not writing that in the PR