search

Saeven / zf3-circlical-user

Turnkey Authentication, Identity, and RBAC for Laminas and Zend Framework 3. Supports Doctrine and Middleware.
Mozilla Public License 2.0
36 stars 15 forks source link

Update Laminas Cache modules in composer.json #79

Closed CreativeNative closed 3 years ago

CreativeNative commented 3 years ago

The problem is that you replace all cache adapters, which makes it impossible to install any cache module. For example APCu or Filesystem are not deprecated. Please update the composer file as follows;

"replace": { "laminas/laminas-cache-storage-adapter-apc": "", "laminas/laminas-cache-storage-adapter-dba": "", "laminas/laminas-cache-storage-adapter-memcache": "", "laminas/laminas-cache-storage-adapter-memcached": "", "laminas/laminas-cache-storage-adapter-mongodb": "", "laminas/laminas-cache-storage-adapter-wincache": "", "laminas/laminas-cache-storage-adapter-xcache": "", "laminas/laminas-cache-storage-adapter-zend-server": "" }

https://github.com/doctrine/DoctrineModule#note-on-php-80-or-later

CreativeNative commented 3 years ago

Would be also good to update doctrine-module to version 4.2.

CreativeNative commented 3 years ago

I forked your project to update the composer.json by my own. Actually it's better to delete the whole "replace" section, because it can't exist 2 times, when the user has it also in his composer.json.

When trying so, you get the following error in composer: "They both replace laminas/laminas-cache-storage-adapter-apc and thus cannot coexist."

At this point I think it would make more sense to let choose the owner and maybe advise him in the documentation, that he has to do so. What do you think?

I try to get everything working and want to add also some extras like psalm and phpstan to ypur project. Send you some PR's in the next days, ok?