Saeven / zf3-circlical-user

Turnkey Authentication, Identity, and RBAC for Laminas and Zend Framework 3. Supports Doctrine and Middleware.
Mozilla Public License 2.0
36 stars 15 forks source link

Updates composer.json and documentation for installation #80

Closed CreativeNative closed 3 years ago

CreativeNative commented 3 years ago

Deletes the replace section in favor of the owner. In the documentation should be written that the replace section in composer.json is needed for PHP 8.

Updates laminas-cache to min version ^2.13 and doctrine/doctrine-module to min version ^4.2.0.

Fixes #79

Updates in circlical.user.local.php.dist the initial cookie settings: Fixes #85

Saeven commented 3 years ago

Thanks for the PRs @CreativeNative! The only thing I'd like to revert, is settings things to Lax instead of None (which is a default). The reason for this, is that where None is likely to strike a red flag on audited applications, Lax may belie intention where truly, a change should be prompted. I work in a Fortune-100 space where this is often the story. Reducing the chance that something flies under the radar, is often tantamount to success.

If you could revert this small default config change, I would with thanks, happily merge the rest.

🙏🏼

CreativeNative commented 3 years ago

I understand. No problem. I think the advisory is at that point enough.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Saeven commented 3 years ago

This PR causes GitHub actions to fail. Will have to revert the composer cache replacement barring some other solution, @CreativeNative

https://github.com/Saeven/zf3-circlical-user/runs/4134526622?check_suite_focus=true