search

Saeven / zf3-circlical-user

Turnkey Authentication, Identity, and RBAC for Laminas and Zend Framework 3. Supports Doctrine and Middleware.
Mozilla Public License 2.0
36 stars 15 forks source link

Adds updated laminas cache replacement #86

Closed CreativeNative closed 3 years ago

CreativeNative commented 3 years ago

That whole replacement stuff is really dirty and stupid. But nevertheless this will fix it. The problem is, that these replacement options can't exist 2 times.

I activated the workflow now in my fork. So next time it will not happen. Sorry for the inconvenience.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Saeven commented 3 years ago

No problems, I'm certain this is why I had done it the first time. But I'm always open to being wrong. My spidey senses were tingling when I saw this part of your PR.

CreativeNative commented 3 years ago

Rofl, spidey senses. ^^

Can you please help me once more. I activate the workflow in my fork. Unfortunately it doesn't work, because I don't have a CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}. What's that? Is that a paid service?

Would be cool if that workflow would work also in my fork to check primary and push afterwards. Don't want to bother you.

I want to fix the PSR-4 issue and also the huge coding standard issue. Hope you are ok with that. But that will change a lot of code and I want to be sure that everything is running perfectly. And trust me with that coding standard. This package has to be rock solid and this step will bring it far ahead. I saw a lot of dirty stuff in the code base that has to be cleaned up.

Saeven commented 3 years ago

You could probably adjust your workflow to remove CODACY to achieve what you're after yeah. It is a service that is used to track coverage and style and all kinds of violations.

I have to note, in passing, that while I object to the words "huge coding standard issue", I realize that you have good intentions and appreciate that!

I think 'different' is better. Some parts are beneficial, but the whitespace shenanigans are just imposed preferences.

I work 9-5 Mon/Thursday, and have Fridays for OSS work. I'll fire up phpcs with your adjustments, and inject exceptions/modifications that find a middle ground toward the Laminas standard. I think I largely just object to the whitespace impositions.

Dirty is a strong term. But I'm happy to hash them out.

CreativeNative commented 3 years ago

Please don't get me wrong. This project is really awesome. Since years I'm following it and I'm really happy to use it finally. But I saw a lot of dead code and some other not so nice issues that we could get rid of. ;-)

And this whitespace thing isn't really a big deal. You can also exclude it. I'm more interested in strict types and other security benefits.