search

Saeven / zf3-circlical-user

Turnkey Authentication, Identity, and RBAC for Laminas and Zend Framework 3. Supports Doctrine and Middleware.
Mozilla Public License 2.0
36 stars 15 forks source link

Upgrade to Laminas Cache ^3.1.2 or delete the requirement #93

Closed CreativeNative closed 2 years ago

CreativeNative commented 2 years ago

I will try it in my eco system and will send an PR if everything works fine.

CreativeNative commented 2 years ago

In composer.json we need also the laminas-cache-storage-deprecated-factory. Laminas-cache and also doctrine cache are in heavy construction, so actually it's a mess. But at least it's working and compatible with PHP8.0 and maybe also with PHP8.1

"laminas/laminas-cache": "^3.1.2",
"laminas/laminas-cache-storage-deprecated-factory": "^1.0.0",
"laminas/laminas-cache-storage-adapter-blackhole": "^2.0.0",
"laminas/laminas-cache-storage-adapter-filesystem": "^2.0.0",

In modules.config add:

'Laminas\Cache\Module',
'Laminas\Cache\Storage\Adapter\BlackHole',
'Laminas\Cache\Storage\Adapter\Filesystem',
CreativeNative commented 2 years ago

I checked the code. From my point of view it can be deleted. Please check and tell me what do you think.

Saeven commented 2 years ago

Will give this a go. I remember when I last messed with it, laminas-cache was a giant mess. Things do seem to have improved, despite it being a clunky install still. I'll create a PR to prepare for 8.1, and also, to recommend putting the replace blocks in the parent composer.