[Items] Damage Multiplier

[sycchen]

Some bonuses aren't multiplied by multipliers such as criticals, abilities and feats. Make sure we can differentiate between them when looking at damage.

[apravdin]

from what i've seen there are 10 different damage types: Acid,Cold,Fire,Force,Lightning,Necrotic,Poison,Psychic,Radiant,Thunder perhaps we form a tuple of all the damages ((type,value),(type,value)...) and specify which types get multiplier add critical, abilities, and feats as types as well

[Saevon]

don't forget unnamed. adding critical is a bad idea, since the critical damage type is changeable, we shouldn't mix up damage types versus this other grouping system. they overlap and that would make it harder to work with.

The key problem is that certain abilities do want multipliable damage (e.g. +1 weapon) while others add a constant (e.g. flaming burst)

try to isolate each problem into small components that are workable...