search

Saezenn / pe

0 stars 0 forks source link

Overly-stringent input for salary #9

Open Saezenn opened 11 months ago

Saezenn commented 11 months ago

Given that these are salaries, there can be varying wages. A lot of wages in the real world have decimals.

image.png

nus-pe-script commented 11 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Salary should be allowed to be given with decimal place

Description:

As a application for maintaining employee records, it should be possible to specify salaries with cents

Current Implementation:

Only positive integers are allowed for salary

Reason Why its Flawed:

There are many cases were salary could have decimal places, due to certain pay packages and certain percentage based salary increments, e.g. "$1050.30" or "$7.50"

Justification for Severity:

As it is common to see salary ranges with cents, e.g. with part time jobs. It is a feature that can affect many users, hence medium.

[original: nus-cs2103-AY2324S1/pe-interim#2411] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted: Support for salaries with decimal points will be added in a future iteration.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]