Safe-DS / DSL

Statically checked Data Science programs.
https://dsl.safeds.com
MIT License
14 stars 0 forks source link

fix: import error when exploring tables in pipelines that call segments #1074

Closed lars-reimann closed 5 months ago

lars-reimann commented 5 months ago

Summary of Changes

Exploring a table in the following code

package bug

pipeline whoSurvived {
    val titanic = Table.fromCsvFile("titanic.csv");

    val beforeSplit = preprocessBeforeSplit(titanic);
}

segment preprocessBeforeSplit(table: Table) -> result: Table {
    yield result = table;
}

lead to a runtime error cannot import name 'preprocessBeforeSplit' from 'bug.gen_titanic' (unknown location).

The document that was created for profiling was not properly built, so an incorrect import was created for the segment, even though it was in the same document.

github-actions[bot] commented 5 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.12s
✅ TYPESCRIPT eslint 3 0 0 4.38s
✅ TYPESCRIPT prettier 3 0 0 0.9s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7206d62) to head (ef59e41). Report is 95 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1074 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 104 104 Lines 20560 20565 +5 Branches 4061 4061 ========================================= + Hits 20560 20565 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lars-reimann commented 5 months ago

:tada: This PR is included in version 0.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: