Safe-DS / DSL

Statically checked Data Science programs.
https://dsl.safeds.com
MIT License
14 stars 0 forks source link

fix: runner not shutting down when extension was closed #1094

Closed lars-reimann closed 5 months ago

lars-reimann commented 5 months ago

Summary of Changes

Graceful shutdown of the runner now works again.

github-actions[bot] commented 5 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.05s
✅ TYPESCRIPT eslint 1 0 0 4.15s
✅ TYPESCRIPT prettier 1 0 0 0.81s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (31b8a28) to head (9aa5190).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1094 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 104 104 Lines 20599 20599 Branches 4069 4069 ========================================= Hits 20599 20599 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lars-reimann commented 5 months ago

Since the shutdown message was not sent, we got into the 2.5s timeout. Apparently, during this time, the extension host was killed, so it could never tree-kill the spawned processes.

lars-reimann commented 5 months ago

:tada: This PR is included in version 0.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: