feat: check usages of `@PythonName` and `@PythonCall` on overriding methods

Safe-DS / DSL

Statically checked Data Science programs.

https://dsl.safeds.com

MIT License

11 stars 0 forks source link

feat: check usages of `@PythonName` and `@PythonCall` on overriding methods #1100

Closed lars-reimann closed 2 months ago

lars-reimann commented 2 months ago

Summary of Changes

Add some checks:

Must not override method with @PythonCall annotation
Overriding method must not have @PythonCall annotation
Python name of overriding method must equal the python name of the overridden method

github-actions[bot] commented 2 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ REPOSITORY	git_diff	yes		no	0.12s
✅ TYPESCRIPT	eslint	2	0	0	4.24s
✅ TYPESCRIPT	prettier	2	0	0	0.87s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by _

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f6bcd3b) to head (5e47c38). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1100 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 106 106 Lines 20709 20797 +88 Branches 4064 4088 +24 ========================================= + Hits 20709 20797 +88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lars-reimann commented 2 months ago

:tada: This PR is included in version 0.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: