refactor: clean up state and separate it

Safe-DS / DSL

Statically checked Data Science programs.

https://dsl.safeds.com

MIT License

11 stars 0 forks source link

refactor: clean up state and separate it #1170

Closed SmiteDeluxe closed 1 month ago

SmiteDeluxe commented 1 month ago

Closes #1169

Summary of Changes

Split up the currentState into tabs, table and history stores, as no saving to vscode global state anymore so not needed to save as one big object
This means that svelte does not have to reevaluate so many things when something small changes, as in a new history item does not cause update to whole state anymore that causes table to update in background
Also easier to manage and update
tableIdentifier in table object, defaultState property not needed anymore and UserSettings not yet
columns don't have a number anymore as order is just array order
table filter is object that can have all the tablefilters but not multiple of one type
columnWidths still shall remain own store in component, as otherwise resize drag would cause massive amount of updates to the table store
setCurrentState msg is not setInitialTable and takes Table, error if executed more than once

github-actions[bot] commented 1 month ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ JSON	prettier	4	0	0	2.01s
✅ REPOSITORY	git_diff	yes		no	0.22s
✅ TSX	eslint	4	0	0	7.47s
✅ TYPESCRIPT	eslint	6	0	0	7.14s
✅ TYPESCRIPT	prettier	6	0	0	1.2s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by _

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a216743) to head (8a36f5c). Report is 1 commits behind head on main.

:exclamation: Current head 8a36f5c differs from pull request most recent head 49d685f. Consider uploading reports for the commit 49d685f to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1170 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 110 110 Lines 19238 19238 Branches 4114 4114 ========================================= Hits 19238 19238 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lars-reimann commented 1 month ago

Does this PR add new features or is it "only" to refactor? Just asking because of the PR title.

SmiteDeluxe commented 1 month ago

Does this PR add new features or is it "only" to refactor? Just asking because of the PR title.

Oops sorry, not intended. Yes only refactor, changed that title.

lars-reimann commented 1 month ago

:tada: This PR is included in version 0.16.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: