Safe-DS / Library-Analyzer

Analysis of Python libraries and of code that uses them.
https://library-analyzer.safeds.com
MIT License
5 stars 0 forks source link

feat: correct origins for `CombinedCallGraphNodes` #269

Closed lukarade closed 3 months ago

lukarade commented 4 months ago

Closes #267

Summary of Changes

github-actions[bot] commented 4 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 12 0 0 1.81s
✅ PYTHON mypy 12 0 3.76s
✅ PYTHON ruff 12 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.06s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 89.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.87%. Comparing base (492134e) to head (1737a01). Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...er/processing/api/purity_analysis/model/_purity.py 84.78% 7 Missing :warning:
...cessing/api/purity_analysis/_resolve_references.py 85.00% 3 Missing :warning:
...er/processing/api/purity_analysis/_infer_purity.py 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #269 +/- ## ========================================== - Coverage 92.94% 92.87% -0.07% ========================================== Files 98 98 Lines 6818 6853 +35 ========================================== + Hits 6337 6365 +28 - Misses 481 488 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lars-reimann commented 3 months ago

@lukarade I'll review after the conflicts are resolved.

lukarade commented 3 months ago

@lukarade I'll review after the conflicts are resolved.

@lars-reimann Done.

lukarade commented 3 months ago

Very nice, just a few requests regarding types in the documentation.

Since we talked about that on multiple occasions before, and for consistency, all type hints from docstrings were removed.