search

Safe-DS / Runner

Execute Safe-DS programs that were compiled to Python.
MIT License
2 stars 0 forks source link

feat: update to safe-ds 0.17.1 + server refactor #37

Closed WinPlay02 closed 9 months ago

WinPlay02 commented 9 months ago

Summary of Changes

github-actions[bot] commented 9 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 0.58s
✅ PYTHON mypy 5 0 1.72s
✅ PYTHON ruff 5 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cae05c5) 100.00% compared to head (9e86acd) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 11 +1 Lines 377 390 +13 ========================================= + Hits 377 390 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lars-reimann commented 9 months ago

Is this still WIP or ready to merge?

WinPlay02 commented 9 months ago

There is a warning printed on every runner startup since this update, which I am trying to fix, that's why it is still WIP

WinPlay02 commented 9 months ago

It seems like the update to the new library version causes the runner to startup slower (probably because of the larger amount of dependencies).

For the record, this was the warning:

src/safeds_runner/server/main.py:202: MonkeyPatchWarning: Monkey-patching ssl after ssl has already been imported may lead to errors, including RecursionError on Python 3.6. It may also silently lead to incorrect behaviour on Python 3.7. Please monkey-patch earlier. See https://github.com/gevent/gevent/issues/1016. 
Modules that had direct imports (NOT patched): ['urllib3.util (venv\\Lib\\site-packages\\urllib3\\util\\__init__.py)', 'urllib3.util.ssl_ (venv\\Lib\\site-packages\\urllib3\\util\\ssl_.py)'].
  patch_all()

I refactored the main.py a bit to fix this.

lars-reimann commented 8 months ago

:tada: This PR is included in version 0.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: