Open Masara opened 3 months ago
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
β PYTHON | black | 14 | 0 | 0 | 1.59s |
β PYTHON | mypy | 14 | 0 | 6.45s | |
β PYTHON | ruff | 14 | 0 | 0 | 0.04s |
β REPOSITORY | git_diff | yes | no | 0.03s |
See detailed report in MegaLinter reports
_Set VALIDATE_ALL_CODEBASE: true
in mega-linter.yml to validate all sources, not only the diff_
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.84%. Comparing base (
0a8ef17
) to head (fbe2a20
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lars-reimann Could you remind me how the stubs have to handle None
as a return type?
So for example these cases:
def fun1() -> None: ...
def fun2():
return
def fun3():
return None
Should the SDS-Stubs look like this for all three cases:
fun fun*()
?
or should they all have a trailing -> result1: Nothing?
?
Answer to the question:
def fun1() -> None: ...
fun fun1()
def fun2():
return
fun fun2()
def fun3():
return None
fun fun3() -> result1: Nothing?
I decided to not change anything concerning the handling of "None" from the cases stated above, because it seems we already implemented everything concerning that topic already in the past. So the current state would be that every case creates the stubs without the -> result1: Nothing?
part.
@lars-reimann This is ready for a review. I checked the stub changes on the other branch and everything seemed all right to me.
Summary of Changes
raise
s withlogger.info
s.