Closed mitra42 closed 4 years ago
@danaronson was hoping to go over this with you, but guess our schedules didn't overlap today (Thursday SF/Friday NSW is always my busiest day). Would be good to look at this tomorrow as I want to build on it. Once its merged I'll also do a PR which is just re-ordering functions for a logical order, and renaming them for consistency e.g. "_get_file_name_from_file_path"
I figured it would be easier to review the changes I made if I saved the Re-ordering for afterwards
To separate out most of the transforms between key, file_name, file_path, dir, blob, etc