search

Safe2COVIDApp / bct-server

Bluetooth Contact Tracing for Covid19 - server
5 stars 1 forks source link

Expire data in unused_update_tokens #140

Closed mitra42 closed 4 years ago

mitra42 commented 4 years ago

Expire data in unused_update dict

Closes #137

danaronson commented 4 years ago

gack... i think this is confusing, in what cases should you use map_over_dict and which cases shouldn't you? Perhaps if we don't have a clear way of doing this we should just remove it.

mitra42 commented 4 years ago

Good point, I don't have a problem with it being removed - once we had the third dict there are two possibilities a) "Map over all dicts" or b) "map over those dicts that contain data points".

(b) is used just once in _update while (a) is used twice in the expiry process so I arbitrarily chose it.

That doesn't show up in the "files changed" for this PR, but I still think the PR is valid. If you prefer you could remove its use in the two calls at the bottom of contacts.py ?