Dates < <= or what - Githubissues

mitra42 commented 4 years ago

(copied from Slack) So two thoughts…..

for real use, (not testing) then searching for records with date < now would work. It would only miss events that happened at the same second, and would send them at the next poll.
For testing, instead of an HTTP header, we could possibly use the “testing” flag, and use incremental times, or more easily (and following the principle of not having testing and normal behave differently) put in 1-second delays between pings to the server,.

Would that cause anything to be missed, or duplicated. I don’t think so

mitra42 commented 4 years ago

My original 'since < date' fails because it misses anything that came in on the same second as the poll, but after it.

danaronson commented 4 years ago

I would prefer a header, that way we can actually force known uses and not rely on variability. Often in these kinds of tests, time is mocked anyway

On Sat, Apr 25, 2020 at 8:23 PM Mitra Ardron notifications@github.com wrote:

(copied from Slack) So two thoughts…..

for real use, (not testing) then searching for records with date < now would work. It would only miss events that happened at the same second, and would send them at the next poll.

For testing, instead of an HTTP header, we could possibly use the “testing” flag, and use incremental times, or more easily (and following the principle of not having testing and normal behave differently) put in 1-second delays between pings to the server,.

Would that cause anything to be missed, or duplicated. I don’t think so

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mitra42/bct-server/issues/57, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYRXB6CGJRDGHQ32IZNWTROOSLJANCNFSM4MRBBVYQ .

mitra42 commented 4 years ago

Was merged in #58

Safe2COVIDApp / bct-server

Dates < <= or what #57