SafeAILab / EAGLE

Official Implementation of EAGLE
https://arxiv.org/pdf/2406.16858
Apache License 2.0
622 stars 59 forks source link

fix: update verify process #47

Closed cyLi-Tiger closed 4 months ago

cyLi-Tiger commented 4 months ago

I think the verification process needs another condition. According to the prove in SpecInfer, when all candidates in one draft candidate path are accepted, we need to sample the sample_token from the logits of the last accepted node. Here, you still sample from the gtp and the last accepted token is also sampled from gtp, which may cause repetition in the output. Here is what I got from your example.

image

Please correct me if I misunderstood anything!

Liyuhui-12 commented 4 months ago

Thank you.