search

SafeExamBrowser / seb-server

The Safe Exam Browser Server web application simplifies and centralizes the configuration of SEB clients for exams. It interacts with a learning management or exam system for setting up and conducting e-assessments with Safe Exam Browser. It also improves security by allowing to monitor connected SEB clients in real time during e-assessments.
Mozilla Public License 2.0
43 stars 38 forks source link

Added action to build demo docker container #21

Closed BenGig closed 3 years ago

BenGig commented 3 years ago

Added directory docker from https://github.com/SafeExamBrowser/seb-server-setup, changed demo Dockerfile to execute only, removed build definitions

Added build actions

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (f775dda) into master (4ac8f15) will decrease coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #21      +/-   ##
============================================
- Coverage     60.01%   59.73%   -0.28%     
+ Complexity     2201     2189      -12     
============================================
  Files           238      238              
  Lines         12501    12501              
  Branches        914      914              
============================================
- Hits           7502     7467      -35     
- Misses         4381     4419      +38     
+ Partials        618      615       -3
Impacted Files Coverage Δ Complexity Δ
...e/servicelayer/session/impl/ExamUpdateHandler.java 33.33% <0.00%> (-19.45%) 5.00% <0.00%> (-4.00%)
.../webservice/servicelayer/dao/impl/ExamDAOImpl.java 58.09% <0.00%> (-6.07%) 62.00% <0.00%> (-6.00%)
...vicelayer/session/impl/ExamSessionControlTask.java 74.62% <0.00%> (-5.98%) 11.00% <0.00%> (-1.00%)
...rvicelayer/lms/impl/SEBRestrictionServiceImpl.java 9.09% <0.00%> (-3.90%) 2.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ac8f15...f775dda. Read the comment docs.

danschlet commented 3 years ago

As our SEB Server developer is officially on his holiday leave, I just wanted to clarify what the purpose of your pull request is. As far as I understood, all code related to SEB Server setup belongs into the https://github.com/SafeExamBrowser/seb-server-setup repository, not into this one.

BenGig commented 3 years ago

I discussed the issues with Andreas and will close the PR. I first will clean up and then issue another PR. Only a (preferably only one) Dockerfile and an associated build queue should remain.

Background is the distribution of seb-server in Kubernetes. Currently, the docker build is included in docker-compose in the seb-server-setup. This works for standalone containers, but not for Kubernetes, where we need docker images ready to use. The docker image is not really part of the setups but tied to the code. And for a setup for production, we want to be able to select from a list of different immutable releases for upgrade procedures.