search

SafeExamBrowser / seb-server

The Safe Exam Browser Server web application simplifies and centralizes the configuration of SEB clients for exams. It interacts with a learning management or exam system for setting up and conducting e-assessments with Safe Exam Browser. It also improves security by allowing to monitor connected SEB clients in real time during e-assessments.
Mozilla Public License 2.0
46 stars 38 forks source link

Authenticate with OLAT using POST instead of GET #40

Closed sealexan closed 3 years ago

sealexan commented 3 years ago

A very minor security improvement to avoid credentials (visible in a GET call) being accidentally logged.

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (1449de2) into master (dea65b7) will decrease coverage by 2.05%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
- Coverage     50.62%   48.57%   -2.06%     
- Complexity     2475     2497      +22     
============================================
  Files           292      298       +6     
  Lines         17224    18224    +1000     
  Branches       1289     1377      +88     
============================================
+ Hits           8720     8852     +132     
- Misses         7792     8636     +844     
- Partials        712      736      +24
Flag Coverage Δ
unittests 48.57% <0.00%> (-2.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ervicelayer/lms/impl/olat/OlatLmsRestTemplate.java 0.00% <0.00%> (ø)
...layer/lms/impl/edx/OpenEdxRestTemplateFactory.java 0.00% <0.00%> (-69.24%) :arrow_down:
.../session/impl/indicator/AbstractPingIndicator.java 38.88% <0.00%> (-30.68%) :arrow_down:
...yer/lms/impl/edx/OpenEdxLmsAPITemplateFactory.java 66.66% <0.00%> (-27.78%) :arrow_down:
...vicelayer/lms/impl/AbstractCachedCourseAccess.java 0.00% <0.00%> (-18.19%) :arrow_down:
...ervicelayer/dao/impl/ClientInstructionDAOImpl.java 32.30% <0.00%> (-17.70%) :arrow_down:
...vice/servicelayer/dao/impl/ClientEventDAOImpl.java 37.71% <0.00%> (-17.06%) :arrow_down:
...rvicelayer/lms/impl/edx/OpenEdxLmsAPITemplate.java 0.00% <0.00%> (-13.64%) :arrow_down:
.../webservice/servicelayer/dao/ConfigurationDAO.java 12.50% <0.00%> (-12.50%) :arrow_down:
...r/webservice/weblayer/api/IndicatorController.java 62.50% <0.00%> (-8.93%) :arrow_down:
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dea65b7...1449de2. Read the comment docs.