Safecast / safecastapi

The app that powers api.safecast.org
44 stars 25 forks source link

Add "Highest Measurement" field to log approval page #245

Open seanbonner opened 8 years ago

seanbonner commented 8 years ago

Right now we have:

Filename Number Of Lines Number Of Measurements

I'd like to add to that

Highest Measurement

Reason being, with the map only it's too easy to miss a few very high readings on a log where 99.9% of the readings are within normal scope which leads to accidental approval regularly. If we can show "Highest Measurement" then the moderator can quickly see if there is reason to look closer at the log before approving or rejecting.

robouden commented 8 years ago

Maybe easiest way is to use the code we have for Databot (Python).

rob

Regards, Rob Oudendijk Yuka Hayashi http://yr-design.biz http://oudendijk.biz http://about.me/robouden tel +81 80-22605966 Skype: robouden Facebook:robouden http://on.fb.me/QeKw2P twitter:robouden http://bit.ly/RAiSTC

On Sun, Apr 17, 2016 at 7:25 PM, seanbonner notifications@github.com wrote:

Right now we have:

Filename Number Of Lines Number Of Measurements

I'd like to add to that

Highest Measurement

Reason being, with the map only it's too easy to miss a few very high readings on a log where 99.9% of the readings are within normal scope which leads to accidental approval regularly. If we can show "Highest Measurement" then the moderator can quickly see if there is reason to look closer at the log before approving or rejecting.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Safecast/safecastapi/issues/245

nokton commented 8 years ago

There is supposed to be another github request to embed the Databot diagnostics into the drive import and show these on the tab Process Log - that includes peak and error counts, etc.

Pieter

On Apr 17, 2016, at 8:35 PM, Rob Oudendijk notifications@github.com wrote:

Maybe easiest way is to use the code we have for Databot (Python).

rob

Regards, Rob Oudendijk Yuka Hayashi http://yr-design.biz http://yr-design.biz/ http://oudendijk.biz http://oudendijk.biz/ http://about.me/robouden http://about.me/robouden tel +81 80-22605966 Skype: robouden Facebook:robouden <http://on.fb.me/QeKw2P http://on.fb.me/QeKw2P> twitter:robouden <http://bit.ly/RAiSTC http://bit.ly/RAiSTC>

On Sun, Apr 17, 2016 at 7:25 PM, seanbonner <notifications@github.com mailto:notifications@github.com> wrote:

Right now we have:

Filename Number Of Lines Number Of Measurements

I'd like to add to that

Highest Measurement

Reason being, with the map only it's too easy to miss a few very high readings on a log where 99.9% of the readings are within normal scope which leads to accidental approval regularly. If we can show "Highest Measurement" then the moderator can quickly see if there is reason to look closer at the log before approving or rejecting.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub <https://github.com/Safecast/safecastapi/issues/245 https://github.com/Safecast/safecastapi/issues/245>

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Safecast/safecastapi/issues/245#issuecomment-211003810

matschaffer commented 6 years ago

Bumping to next given @nokton's request in slack today

matschaffer commented 6 years ago

@eitoball's fix is looking good on prod:

bgeigie_import__10757____bgeigie_imports____safecast_api

seanbonner commented 6 years ago

Looks like there's some bugs with this. Check this drive:

https://api.safecast.org/en-US/bgeigie_imports/37388

Says highest reading is 141, but mousing over the red spots on the map shows readings over 300. Just saw several like this...

eitoball commented 2 years ago

@seanbonner

I am sorry for taking so long to respond.

Anyway,

Says highest reading is 141,

The highest "logged" CPM value is 141 (177, actually).

but mousing over the red spots on the map shows readings over 300.

Yes, there are. For example,

Screen Shot 2022-09-27 at 9 49 39

dialog says "logged" CPM value (Log CPM) is 141, and CPM value is 324. This 324 is from roughly27 (CP5s) times 12; this makes CPM (Counts Per Minutes) from CP5s (Counts Per 5 seconds). This calculation seems to be called "dead-time correction". Please look for Google for what "dead-time correction". The calculation is for high CPM values, values more than 100 CPM.

Do you want to show highest CPM value that is adjusted with "dead-time correction", or highest "logged" CPM value?

It seems that it is related to #706. @Frangible could comment if I am wrong.