Add link for auto-approved drives

[matschaffer]

Per @seanbonner - it'd be good to have a list of auto-approved drives ready for cross check

Could put it here

[ZacharyCChang0828]

I will try to look at this and see if I can come up with anything on a new branch.

[matschaffer]

Might be good to check or remove those other links too. As far as I can tell they're just searching the wrong thing.

[ZacharyCChang0828]

I actually don't know how to generate links like those in rails so I will be looking into the other links first.

[ZacharyCChang0828]

This is what I found 1."Not processed" is looking for 'submitted' and not yet approved 2."Not approved" is looking for 'processed',but 'not submitted'(and of course unapproved) 3.'Awaiting for' has a broken code, changing the status it is looking for from 'awaiting_for' to 'awaiting_response' makes it work perfectly. 4.Azby wants to keep all three functions above and add another "rejected" link, the wording for the above link should also be fixed to make it less confusing

[matschaffer]

Nice, Zachary! Those sound like solid updates

On Tue, Dec 3, 2019 at 16:09 Zachary Chang notifications@github.com wrote:

This is what I found 1."Not processed" is looking for 'submitted' and not yet approved 2."Not approved" is looking for 'processed',but 'not submitted'(and of course unapproved) 3.'Awaiting for' has a broken code, changing the status it is looking for from 'awaiting_for' to 'awaiting_response' makes it work perfectly. 4.Azby wants to keep all three functions above and add another "rejected" link, the wording for the above link should also be fixed to make it less confusing

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Safecast/safecastapi/issues/599?email_source=notifications&email_token=AAAAFMVYPYT2RYYE64LJ5XDQWYA3LA5CNFSM4JS345T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYKZ3Y#issuecomment-561032431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAFMXJNDWN3NDQTNUBJCDQWYA3LANCNFSM4JS345TQ .

--

-Mat

matschaffer.com

[Azby]

Yes, we just discussed it. Others of us have talked about this recently as well. I think it would be very useful to have these bins:

1) “Not Processed”: It should show uploads that have not been processed for some reason, more for trouble shooting than anything else I think. 2) "Not Submitted” : So we can see how many drives are in limbo because the user forgot to submit them etc. 3) “Not Approved” : This would be submitted but so far unapproved drives, meaning in most cases that no moderator has looked at them yet. I.e “Waiting for moderation.” 4) “Rejected”: This would be files that have been intentionally rejected by a moderator, showing by whom and when. Ideally the moderator would put the reasonfor rejection into that upload’s metadata comments field. 5) “Awaiting Reply”: Rename the “Waiting for…” field, since this lists uploads whose user has been contacted, by whom, and when.

What do you all think?

On Dec 3, 2019, at 16:09, Zachary Chang notifications@github.com wrote:

This is what I found 1."Not processed" is looking for 'submitted' and not yet approved 2."Not approved" is looking for 'processed',but 'not submitted'(and of course unapproved) 3.'Awaiting for' has a broken code, changing the status it is looking for from 'awaiting_for' to 'awaiting_response' makes it work perfectly. 4.Azby wants to keep all three functions above and add another "rejected" link, the wording for the above link should also be fixed to make it less confusing

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Safecast/safecastapi/issues/599?email_source=notifications&email_token=ABB7ADWAKJXYN5VBKNPQJLLQWYA3PA5CNFSM4JS345T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYKZ3Y#issuecomment-561032431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB7ADSRN3IO37WFCG7AMSDQWYA3PANCNFSM4JS345TQ.

[seanbonner]

This all sounds great, but just to reiterate the initial request, I'd like to see a link of drives that ARE auto approved (or rather, would be if in auto mode).

[Azby]

Yes, agree. Zachary pointed that out yesterday as well.

On Dec 4, 2019, at 7:29, Sean Bonner notifications@github.com wrote:

This all sounds great, but just to reiterate the initial request, I'd like to see a link of drives that ARE auto approved (or rather, would be if in auto mode).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Safecast/safecastapi/issues/599?email_source=notifications&email_token=ABB7ADWNADCIL22E5JLEHZDQW3MS5A5CNFSM4JS345T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3BHFA#issuecomment-561386388, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB7ADVI5ZFLBTLRS5H2O73QW3MS5ANCNFSM4JS345TQ.

[Lugulbanda]

whats the difference between new and processed in the user api?

Gesendet mit der GMX Mail App

Am 03.12.19 um 08:19 schrieb Azby

Yes, we just discussed it. Others of us have talked about this recently as well. I think it would be very useful to have these bins:

1) “Not Processed”: It should show uploads that have not been processed for some reason, more for trouble shooting than anything else I think.

2) "Not Submitted” : So we can see how many drives are in limbo because the user forgot to submit them etc.

3) “Not Approved” : This would be submitted but so far unapproved drives, meaning in most cases that no moderator has looked at them yet. I.e “Waiting for moderation.”

4) “Rejected”: This would be files that have been intentionally rejected by a moderator, showing by whom and when. Ideally the moderator would put the reasonfor rejection into that upload’s metadata comments field.

5) “Awaiting Reply”: Rename the “Waiting for…” field, since this lists uploads whose user has been contacted, by whom, and when.

What do you all think?

On Dec 3, 2019, at 16:09, Zachary Chang notifications@github.com wrote:

This is what I found

1."Not processed" is looking for 'submitted' and not yet approved

2."Not approved" is looking for 'processed',but 'not submitted'(and of course unapproved)

3.'Awaiting for' has a broken code, changing the status it is looking for from 'awaiting_for' to 'awaiting_response' makes it work perfectly.

4.Azby wants to keep all three functions above and add another "rejected" link, the wording for the above link should also be fixed to make it less confusing

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub https://github.com/Safecast/safecastapi/issues/599?email_source=notifications&email_token=ABB7ADWAKJXYN5VBKNPQJLLQWYA3PA5CNFSM4JS345T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYKZ3Y#issuecomment-561032431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB7ADSRN3IO37WFCG7AMSDQWYA3PANCNFSM4JS345TQ.

--

You are receiving this because you are subscribed to this thread.

Reply to this email directly or view it on GitHub:

https://github.com/Safecast/safecastapi/issues/599#issuecomment-561035018

[matschaffer]

new (https://api.safecast.org/en-US/bgeigie_imports?by_status=unprocessed&locale=en-US&order=created_at+asc) is uploaded but not processed (method is at https://github.com/Safecast/safecastapi/blob/master/app/models/bgeigie_import.rb#L94)

processed (https://api.safecast.org/en-US/bgeigie_imports?by_status=processed&locale=en-US&order=created_at+asc) is the next step

Ideally we shouldn't have anything in new, but looks like we have a few there (two from you).

Thanks for the heads up, will see if I can figure out what held up processing.

[ZacharyCChang0828]

The links should be turned on now. There is some problem with the name of the page being incorrect, and I will try to fix that as soon as possible.

Awaiting_reponse, Auto_approved, Rejected are added and only moderators and view them from the sidebar page.

However, for the other links, at the bgeigie_import page, there already exists a navbar that will show only New, Processed, Submitted, and Approved, which is showing the same drives as not processed, etc.

It Doesn't seem meaningful to have a separate one for moderators unless some columns that should only be visible to moderators, or some functions that should only be given to moderators.

What do you think?

[matschaffer]

I think the intent of the moderator-only links was to provide moderators with an easy "inbox" of things that needed attention.

As far as I know there's no need for any sort of visibility control.

In practice I know @nokton uses https://api.safecast.org/en-US/bgeigie_imports?by_status=submitted&locale=en-US&order=created_at+asc for approving rather than the moderator links because:

1. the query scopes have been incorrect for some time and
2. those moderator-only links don't provide any kind of sorting or filtering control to allow more straightforward drives to be approved when time doesn't allow for more complex analysis of difficult-to-approve drives.

[ZacharyCChang0828]

I had a few discussion with Pieter, and Azby on this topic. It seems like they use the bgeigie_import more often than this view since it has the nice sorting function so it doesn't seems to be worth while developing this view further down, though it doesn't seems necessary to delete anything.

Beside, It might make more sense to enhance the bgeigie_import page more. As a start, I added two pieces of information on the table:

-'comment' row -maximum cpm

These two pieces of information are reported to be useful for moderators.

I wasn't too familiar with how the whole table in the view work so I couldn't get the sorting by clicking on comment right. Right now it will return an error.

The comment row is also now visible to all user, but it might make sense to make it visible to moderator.