search

SaferMobile / InTheClear

Java and Android mobile alerting and secure wipe application(s)
https://lab.safermobile.org/wiki/InTheClear
GNU General Public License v3.0
23 stars 19 forks source link

Testing Emergency SMS Always reports success! #36

Closed djhalliday closed 13 years ago

djhalliday commented 13 years ago

Wizard Screen #2 -

Just tested using a fake, 9 digit number and the app reported success immediately. Something fishy going on here...

harlo commented 13 years ago

Kind of: android will attempt any input as long as it's not null/blank. I suppose it could use a number validation method? In which case, different regions could require different validation methods (which actually seem do-able if we base it off of the user's country code...)

On Thu, Aug 11, 2011 at 3:30 PM, djhalliday < reply@reply.github.com>wrote:

Wizard Screen #2 -

Just tested using a fake, 9 digit number and the app reported success immediately. Something fishy going on here...

Reply to this email directly or view it on GitHub: https://github.com/SaferMobile/InTheClear/issues/36

djhalliday commented 13 years ago

is there any way that we can confirm that the device actually sent an SMS successfully? i.e. beyond form validation, some way to know that it was accepted by the messaging app (or whatever)...

harlo commented 13 years ago

yes you can! i made some progress on this over the weekend: the sms manager will send a result code on a successful send. currently working on implementing this in the SMSSender class in a way that's reusable in whatever context the app requires...

harlo commented 13 years ago

ok, fixed.

djhalliday commented 13 years ago

seeing some string mixups on my local build (i.e. button title now 'SMS Test Failure'). maybe something weird on my end?

harlo commented 13 years ago

weird. that has happened to me before, though. i don't have any fixes, though.

On Mon, Aug 15, 2011 at 3:25 PM, djhalliday < reply@reply.github.com>wrote:

seeing some string mixups on my local build (i.e. button title now 'SMS Test Failure'). maybe something weird on my end?

Reply to this email directly or view it on GitHub: https://github.com/SaferMobile/InTheClear/issues/36#issuecomment-1810237

harlo commented 13 years ago

you might try regenerating R? ultimately, the strings could use some cleaning up eventually (but this will be another issue).

On Mon, Aug 15, 2011 at 3:32 PM, Harlo Holmes harlo.holmes@gmail.comwrote:

weird. that has happened to me before, though. i don't have any fixes, though.

On Mon, Aug 15, 2011 at 3:25 PM, djhalliday < reply@reply.github.com>wrote:

seeing some string mixups on my local build (i.e. button title now 'SMS Test Failure'). maybe something weird on my end?

Reply to this email directly or view it on GitHub: https://github.com/SaferMobile/InTheClear/issues/36#issuecomment-1810237

djhalliday commented 13 years ago

i think that's exactly what it was. all good!