Behind the scenes I rebuilt the way CSV files are loaded in the template file. Essentially instead of loading each file independently, we open the entire folder and then parse the CSVs.
This should trigger only one security check, rather than a check per file and hopefully result in less errors.
Problem description
Pros/cons of approach implemented
Checklist
[ ] Is this PR a reasonable size?
[ ] List deployment sequence with all relevant PRs.
...
Code Review Guidelines for Reviewers
Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
Overall design and approach should follow established patterns. Don't try to make the PR perfect.
Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
If you don't feel qualified to review the code, pass it on to someone who is.
Summary
Behind the scenes I rebuilt the way CSV files are loaded in the template file. Essentially instead of loading each file independently, we open the entire folder and then parse the CSVs.
This should trigger only one security check, rather than a check per file and hopefully result in less errors.
Problem description
Pros/cons of approach implemented
Checklist
Code Review Guidelines for Reviewers