fix connect-web integration instruction - Githubissues

SafetyCulture / grpc-web-devtools

Chrome & Firefox Browser extension to aid gRPC-Web development

MIT License

402 stars 51 forks source link

fix connect-web integration instruction #160

Open idbolshakov opened 1 year ago

idbolshakov commented 1 year ago

Summary

Fix for the connect-web integration instruction

Problem description

There is a syntax error in the current instruction. undefined should not be wrapped with quotes

Pros/cons of approach implemented

not applicable for the current PR I think

Checklist

[x] Is this PR a reasonable size?

Code Review Guidelines for Reviewers

Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
Overall design and approach should follow established patterns. Don't try to make the PR perfect.
Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
If you don't feel qualified to review the code, pass it on to someone who is.