Open will-osborne opened 4 months ago
This change enables visibility of default values in the request and response objects. E.g empty strings and false booleans. what would have show as this before
{ "foo": "bar" }
Looks like this after
{ "foo": "bar", "baz": "", importantBoolean: false }
Not displaying defalt values is misleading and is against the idioms of GRPC.
Pros: It's simple and uses existing functionality. Cons: It's non-configurable.
Code Review Guidelines for Reviewers
Summary
This change enables visibility of default values in the request and response objects. E.g empty strings and false booleans. what would have show as this before
Looks like this after
Problem description
Not displaying defalt values is misleading and is against the idioms of GRPC.
Pros/cons of approach implemented
Pros: It's simple and uses existing functionality. Cons: It's non-configurable.
Checklist
Code Review Guidelines for Reviewers