Change config.size_options to config.point_size_options

SafetyGraphics / hep-explorer

Interactive Graphic for Exploring Liver Function Data in Clinical Trials

https://safetygraphics.github.io/hep-explorer/test/

MIT License

10 stars 3 forks source link

Change config.size_options to config.point_size_options #148

Closed jwildfire closed 6 years ago

jwildfire commented 6 years ago

config.details and config.unit_col in particular

jwildfire commented 6 years ago

Resolve size_options vs. point_size

jwildfire commented 6 years ago

config.details is used to populate the participant meta data when a point is clicked.

jwildfire commented 6 years ago

size_options and point_size are both used. size_options is used to populate the dropdown, while point_size represents the currently selected option. I'm renaming size_options to point_size_options and updating the wiki to make the relationship more transparent.

cc: @bzkrouse

jwildfire commented 6 years ago

removing unit_col option for v1.0.

jwildfire commented 6 years ago

Changed name of issue to represent the only actual code change resulting from this review.