Clicking on point causes stack size error

SafetyGraphics / hep-explorer

Interactive Graphic for Exploring Liver Function Data in Clinical Trials

https://safetygraphics.github.io/hep-explorer/test/

MIT License

10 stars 3 forks source link

Clicking on point causes stack size error #156

Closed bzkrouse closed 6 years ago

bzkrouse commented 6 years ago

Behavior observed in R implementation on Windows machine in enlarged viewer window and/or web browser (oddly, behavior is normal in the small RStudio viewer window).

For the problematic situations, clicking on point successfully generates participant details but neither of the subsequent displays. Specifically, the following behavior/error is observed in console upon clicking on point:

jwildfire commented 6 years ago

Will investigate next week. Curious to see:

whether this was introduced in v0.16.0 or happened in earlier builds
whether it happens with data sets of all sizes

jwildfire commented 6 years ago

In fact, @bzkrouse: if you have time, could you subset the test data and see if the error still occurs when the data set is cut down to only a few subjects?

bzkrouse commented 6 years ago

@jwildfire sure - and yes, the error remains with 5 subjects :(

jwildfire commented 6 years ago

Updated the R package to use to the latest commits for both eDish and webcharts, and tested in Rstudio on mac and PC using the code below. Stack error appears to be resolved in both environments. @bzkrouse can you confirm?

devtools::install_github("ASA-DIA-InteractiveSafetyGraphics/ReDish", ref="v0.1.1-dev")
library(ReDish)
eDISH(data=adlbc)

bzkrouse commented 6 years ago

@jwildfire working for me on Windows/PC!