search

SafetyGraphics / hep-explorer

Interactive Graphic for Exploring Liver Function Data in Clinical Trials
https://safetygraphics.github.io/hep-explorer/test/
MIT License
9 stars 3 forks source link

Dev v1.4 #326

Closed jwildfire closed 3 years ago

jwildfire commented 3 years ago

Overview

This PR adds an nR ratio calculation to the hep-explorer and allows users to show r ratio and nR ratio on the x and y axis. Fixes #323.

Test Notes

We need to QC the nR ratio calculations before release via double programming using the data sets described below. General idea is to have a tester independently re-calculate participant-level nR ratio data and confirm that it matches the derived data in the tool. Would be good to do this in an R script, and perhaps save it in the `/test/ folder in this repo - like @samussiah did for pAlt here. See here for the nR ratio formula.

Three data sets can be downloaded for any version of the chart by clicking the "↓ Raw Data" button at the top of the page.

jwildfire commented 3 years ago

@samussiah Thanks for working on this a little while back. Would like to get this merged before the safetyGraphics v2 release. Do you remember where you left this? Any ideas on next steps?

samussiah commented 3 years ago

@samussiah Thanks for working on this a little while back. Would like to get this merged before the safetyGraphics v2 release. Do you remember where you left this? Any ideas on next steps?

@jwildfire I basically reproduced every subject nR Ratio plot in R and compared them with the app... Let me double check the comparisons and get back to you. Do you have any suggestions on a more automated approach? Perhaps writing a little .js function that exposes the nR ratio calculations for comparison in R?

jwildfire commented 3 years ago

Let me double check the comparisons and get back to you. Do you have any suggestions on a more automated approach? Perhaps writing a little .js function that exposes the nR ratio calculations for comparison in R?

I basically did this - from the test notes in the PR above:

Visit-level nR Ratio data - This is the visit-level nR ratio data as derived by the tool. It is one record per person per visit. The "value" colum has the nR ratio calculation at that time point. To download, click the "↓ Raw Data" button while holding the alt key.

So, seems like we could just pull that .csv, save it to your new validation folder and then do a quick compare.

samussiah commented 3 years ago

I'll knock it out shortly.