search

SafetyGraphics / nepExplorer

Interactive Graphic for Exploring Kidney Function Data in Clinical Trials
https://safetygraphics.github.io/nepExplorer/
MIT License
6 stars 0 forks source link

use settings object instead of renaming columns, following volcanoplo… #97

Closed pburnsdata closed 1 year ago

pburnsdata commented 1 year ago

Originally I renamed the columns in the top level module and then used the new names in other functions/modules. However, I noticed volcanoplot just passes the settings object everywhere. It feels less readable to me, but it does clear need for global vars for cmd check (and ultimately zzz.R perhaps) and the rename did feel hacky....

closes #96 closes #98

pburnsdata commented 1 year ago

@elimillera Updated all the references, and went ahead and did the rest of the global vars to be consistent, so was able to get rid of zzz.R for now. Ready for review again!