search

SafetyGraphics / safetyCharts

Charts for monitoring clinical trial safety designed for use with {safetyGraphics}
Other
8 stars 7 forks source link

Add crosstalk support? #113

Closed pburnsdata closed 2 years ago

pburnsdata commented 2 years ago

I wanted to add a filter control to an rmd to filter safety outlier explorer and immediately thought of using crosstalk. Not sure how much of a demand there is for this, but we could potentially add support for crosstalk at some point?https://rstudio.github.io/crosstalk/authoring.html

pburnsdata commented 2 years ago

alternatively I could just get a filter via the already built option in js config... that would be way less work haha

pburnsdata commented 2 years ago

Yeah, I simply specified

filters: 
  - value_col: SITE

in the yaml and that did the trick - so for my use case crosstalk seems pretty low priority, but maybe there's other functionality people would want...

jwildfire commented 2 years ago

Yeah, you almost definitely want to add chart-specific filters via the chart config (and pass that through to js).

I do think there's a use case for crosstalk (or maybe custom event triggers) - here's an ancient safetyGraphics issue that touches on that: https://github.com/SafetyGraphics/safetyGraphics/issues/339

Going to close this one. Feel free to add comments on the issue above if you want to pursue this further.